[Lldb-commits] [PATCH] suppress compiler warning (mostly -Wsign-compare)

Chilledheart rwindz0 at gmail.com
Wed Feb 4 10:08:01 PST 2015


Although there are still some Wsign-compare warnings outside this patch, I think this diff is good enough for its own purpose.

I am fine with landing it if there is no further issue.

BTW Here are the warnings I faced on Linux:

  /home/chilledheart/sources-llvm/llvm_lldb/tools/lldb/source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.cpp:749:35: warning: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Wsign-compare]
                  if (machine_regno == m_machine_fp_regnum)
                      ~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~
  /home/chilledheart/sources-llvm/llvm_lldb/tools/lldb/source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.cpp:845:53: warning: comparison of integers of different signs: 'int' and 'lldb::addr_t' (aka 'unsigned long') [-Wsign-compare]
              if (current_func_text_offset + insn_len < m_func_bounds.GetByteSize())
                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
  2 warnings generated.


http://reviews.llvm.org/D6271

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list