[Lldb-commits] [PATCH] Add/update tests for lldb-mi

Hafiz Abid Qadeer abidh.haq at gmail.com
Wed Feb 4 09:11:11 PST 2015


Some observations:

1. I think you should have posted the pieces that dont depend on other patches. In this way, they can be reviewed and committed without waiting on others.
2. The start and end address of 0 is still there in data disassemble command. Probably we can use a function address as start. Then end address can be start + 20 or something. If $pc is supported then that can be used too. GDB does a similar thing.
3. I don't like interpreter-exec much. I think it should only be used if you can not do stuff using other MI commands.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D7410

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list