[Lldb-commits] [PATCH] Add PowerPC FPR access to the process monitor

[Ed Maste]

================
Comment at: source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_powerpc.cpp:149
@@ -148,1 +148,3 @@
             return false;
+        uint8_t *src = (uint8_t *)&m_fpr_powerpc + reg_info->byte_offset;
+        value.SetUInt64(*(uint64_t*)src);
----------------
double-check spaces vs tabs here

================
Comment at: source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_powerpc.cpp:174-175
@@ -184,3 +173,4 @@
 
     if (IsGPR(reg))
         return WriteRegister(reg, value);
+    else if (IsFPR(reg))
----------------
Minor style point, I think it's better to have braces on all branches if any do.

http://reviews.llvm.org/D7040

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/