[Lldb-commits] [PATCH] Get test/types tests passing on remote targets

[Vince Harron]

Looks like I got my diff backwards *blush*
 On Jan 28, 2015 9:44 AM, "Oleksiy Vyalov" <ovyalov at google.com> wrote:

> Please see my comments.
>
>
> REPOSITORY
>   rL LLVM
>
> ================
> Comment at: source/Commands/CommandObjectPlatform.cpp:2284
> @@ -2283,2 +2283,3 @@
>      LoadSubCommand ("settings", CommandObjectSP (new
> CommandObjectPlatformSettings (interpreter)));
> +#ifdef LLDB_CONFIGURATION_DEBUG
>      LoadSubCommand ("mkdir", CommandObjectSP (new
> CommandObjectPlatformMkDir (interpreter)));
> ----------------
> Why we don't need mkdir.. put-file commands in non-debug configurations?
>
> ================
> Comment at: test/types/AbstractBase.py:53
> @@ -52,3 +52,3 @@
>      # bc -> blockCaptured (defaulted to False)
>      #
> -    #         True: testing vars of various basic types from inside a
> block    #
> +    #         True: testing vars of various basic types from isnide a
> block    #
>      #         False: testing vars of various basic types from a function
>      #
> ----------------
> inside?
>
> ================
> Comment at: test/types/AbstractBase.py:91
> @@ -90,7 +90,3 @@
>          # series of printf statements.
> -
> -        # process launch command output redirect always goes to host the
> process is running on
> -        self.runCmd('process launch -o /tmp/golden-output.txt')
> -        # if this is a remote test, get-file will copy it back over, else
> it will just copy
> -        self.runCmd('platform get-file /tmp/golden-output.txt
> "%s"'%(self.golden_filename))
> +        self.runCmd('process launch -o "%s"'%(self.golden_filename))
>          with open(self.golden_filename) as f:
> ----------------
> You may use "platform process launch" here in order to make it work either
> locally or remotely.
>
> http://reviews.llvm.org/D7221
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150128/45402783/attachment.html>