[Lldb-commits] [PATCH] Fix test_nonrunning_command_abbreviations in AbbreviationsTestCase after r226068

Ilia K ki.stfu at gmail.com
Tue Jan 20 05:34:10 PST 2015


This patch fixes the following:
```
$ ./dotest.py -v --executable $BUILDDIR/bin/lldb -f AbbreviationsTestCase.test_nonrunning_command_abbreviations
['./dotest.py', '-v', '--executable', '/Users/IliaK/p/llvm/build_ninja/bin/lldb', '-f', 'AbbreviationsTestCase.test_nonrunning_command_abbreviations']
LLDB library dir: /Users/IliaK/p/llvm/build_ninja/bin
lldb-330.99.0
lldb.pre_flight: None
lldb.post_flight: None

Session logs for test failures/errors/unexpected successes will go into directory '2015-01-20-16_17_43'
Command invoked: ./dotest.py -v --executable /Users/IliaK/p/llvm/build_ninja/bin/lldb -f AbbreviationsTestCase.test_nonrunning_command_abbreviations
compilers=['clang']

Configuration: arch=x86_64 compiler=clang
----------------------------------------------------------------------
Collected 1 test

1: test_nonrunning_command_abbreviations (TestAbbreviations.AbbreviationsTestCase) ... FAILURE

======================================================================
FAIL: test_nonrunning_command_abbreviations (TestAbbreviations.AbbreviationsTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/IliaK/p/llvm/tools/lldb/test/functionalities/abbreviation/TestAbbreviations.py", line 37, in test_nonrunning_command_abbreviations
    startstr = "The following is a list of built-in, permanent debugger commands:")
  File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 2011, in expect
    msg if msg else EXP_MSG(str, exe))
AssertionError: False is not True : 'h' returns expected result
Config=x86_64-clang
----------------------------------------------------------------------
Ran 1 test in 0.966s

FAILED (failures=1)
Session logs for test failures/errors/unexpected successes can be found in directory '2015-01-20-16_17_43'
```

Bug was introduced by r226068 - Three related changes to help.

http://reviews.llvm.org/D7066

Files:
  test/functionalities/abbreviation/TestAbbreviations.py

Index: test/functionalities/abbreviation/TestAbbreviations.py
===================================================================
--- test/functionalities/abbreviation/TestAbbreviations.py
+++ test/functionalities/abbreviation/TestAbbreviations.py
@@ -34,7 +34,7 @@
 
         # Only one matching command: execute it.
         self.expect("h",
-                    startstr = "The following is a list of built-in, permanent debugger commands:")
+                    startstr = "Debugger commands:")
 
         # Execute cleanup function during test tear down
         def cleanup():

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7066.18425.patch
Type: text/x-patch
Size: 583 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150120/859ac478/attachment.bin>


More information about the lldb-commits mailing list