[Lldb-commits] [PATCH] remote-gdb-server platform able to run processes on a remote system

Vince Harron vharron at google.com
Sun Jan 18 23:15:08 PST 2015


Hi clayborg,

This patch gets remote-gdb-server platform able to run processes on a remote system

1) Make sure the selected platform is always used
2) Make sure that the host uses the connect://hostname to connect to both the lldb-platform and the lldb-gdbserver rather than what the platform reports as the hostname of the lldb-gdbserver
3) Make sure that lldb-platform uses the IP address on it's connection back to the host instead of the hostname that the host sends to it when launching lldb-gdbserver with the remote host information

Details:

source/Commands/CommandObjectPlatform.cpp
added SetSelectedPlatform call, because this is what SB does
source/Commands/CommandObjectTarget.cpp
removed m_platform_options - why was it ever in target?
calling CreateTarget with the selected platform (remote-gdb-server) instead of using m_platform_options, which was creating and using a new "host" platform instead of whatever is selected
source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp
implemented PlatformRemoteGDBServer::ResolveExecutable, mostly copied from iOS version
added primitive PlatformRemoteGDBServer::GetSupportedArchitectureAtIndex implementation
PlatformRemoteGDBServer::ConnectRemote - retaining hostname where lldb-platform is running so we can re-use it when we connect to the gdb server.
source/Target/Platform.cpp
implemented Platform::PutFile
source/Target/TargetList.cpp
make sure we're using a platform if one is selected

http://reviews.llvm.org/D7049

Files:
  source/Commands/CommandObjectPlatform.cpp
  source/Commands/CommandObjectTarget.cpp
  source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp
  source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.h
  source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  source/Target/Platform.cpp
  source/Target/TargetList.cpp
  tools/lldb-gdbserver/lldb-gdbserver.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7049.18370.patch
Type: text/x-patch
Size: 18866 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150119/2c8f1073/attachment.bin>


More information about the lldb-commits mailing list