[Lldb-commits] [PATCH] UriParser - fixed potential buffer overrun

[Greg Clayton]

I would prefer this to use Args::StringToUInt32() instead of a manual call to strtoul() from #include "lldb/Interpreter/Args.h" (even though the correct usage of strtoul() is used here). This helps abstract us from the host we are running on in case there is no strtoul() and also leads me to the fact that the Args::StringTo* calls could actually be moved into the host layer.

You might also be better off using the RegularExpression class to parse these instead of sscanf, but this isn't a required change.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D6918

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/