[Lldb-commits] [PATCH] Remove now unneccessary expected failure decorators for Linux.

[Siva Chandra]

Hi vharron,

The tests touched here mostly test basic features of LLDB. They are not
failing anymore. If they start failing again, the right approach would be
to fix them instead of marking them as "expectedFailure". Note also that
some of the referred bugs are already marked as resolved.

http://reviews.llvm.org/D6910

Files:
  test/expression_command/call-function/TestCallStopAndContinue.py
  test/functionalities/attach_resume/TestAttachResume.py
  test/functionalities/embedded_interpreter/TestConvenienceVariables.py
  test/functionalities/inferior-assert/TestInferiorAssert.py
  test/lang/c/tls_globals/TestTlsGlobals.py
  test/lang/cpp/dynamic-value/TestDynamicValue.py
  test/python_api/lldbutil/process/TestPrintStackTraces.py
  test/python_api/value_var_update/TestValueVarUpdate.py

Index: test/expression_command/call-function/TestCallStopAndContinue.py
===================================================================
--- test/expression_command/call-function/TestCallStopAndContinue.py
+++ test/expression_command/call-function/TestCallStopAndContinue.py
@@ -31,7 +31,6 @@
     @dwarf_test
     @expectedFailureDarwin("llvm.org/pr20274") # intermittent failure on MacOSX
     @expectedFailureFreeBSD("llvm.org/pr20274") # intermittent failure
-    @expectedFailureLinux("llvm.org/pr20274") # intermittent failure on Linux
     def test_with_dwarf(self):
         """Test gathering result from interrupted function call."""
         self.buildDwarf()
Index: test/functionalities/attach_resume/TestAttachResume.py
===================================================================
--- test/functionalities/attach_resume/TestAttachResume.py
+++ test/functionalities/attach_resume/TestAttachResume.py
@@ -22,7 +22,6 @@
         self.buildDwarf()
         self.process_attach_continue_interrupt_detach()
 
-    @expectedFailureLinux('llvm.org/pr19478')
     @skipIfRemote
     def process_attach_continue_interrupt_detach(self):
         """Test attach/continue/interrupt/detach"""
Index: test/functionalities/embedded_interpreter/TestConvenienceVariables.py
===================================================================
--- test/functionalities/embedded_interpreter/TestConvenienceVariables.py
+++ test/functionalities/embedded_interpreter/TestConvenienceVariables.py
@@ -20,7 +20,6 @@
     @dwarf_test
     @skipIfFreeBSD # llvm.org/pr17228
     @skipIfRemote
-    @expectedFailureLinux("llvm.org/pr20276") # intermittent failure on Linux
     def test_with_dwarf_and_run_commands(self):
         """Test convenience variables lldb.debugger, lldb.target, lldb.process, lldb.thread, and lldb.frame."""
         self.buildDwarf()
Index: test/functionalities/inferior-assert/TestInferiorAssert.py
===================================================================
--- test/functionalities/inferior-assert/TestInferiorAssert.py
+++ test/functionalities/inferior-assert/TestInferiorAssert.py
@@ -60,7 +60,8 @@
         self.inferior_asserting_expr()
 
     @expectedFailurei386('llvm.org/pr17384: lldb needs to be aware of linux-vdso.so to unwind stacks properly')
-    @unittest2.expectedFailure("rdar://15367233")
+    @expectedFailureDarwin("rdar://15367233")
+    @expectedFailureFreeBSD
     @expectedFailureWindows("llvm.org/pr21793: need to implement support for detecting assertion / abort on Windows")
     def test_inferior_asserting_expr(self):
         """Test that the lldb expression interpreter can read from the inferior after asserting (command)."""
Index: test/lang/c/tls_globals/TestTlsGlobals.py
===================================================================
--- test/lang/c/tls_globals/TestTlsGlobals.py
+++ test/lang/c/tls_globals/TestTlsGlobals.py
@@ -19,7 +19,8 @@
         self.tls_globals()
 
     @dwarf_test
-    @unittest2.expectedFailure("rdar://7796742")
+    @expectedFailureDarwin("rdar://7796742")
+    @expectedFailureFreeBSD
     def test_with_dwarf(self):
         """Test thread-local storage."""
         self.buildDwarf()
Index: test/lang/cpp/dynamic-value/TestDynamicValue.py
===================================================================
--- test/lang/cpp/dynamic-value/TestDynamicValue.py
+++ test/lang/cpp/dynamic-value/TestDynamicValue.py
@@ -21,7 +21,6 @@
         self.do_get_dynamic_vals()
 
     @expectedFailureFreeBSD # FIXME: This needs to be root-caused.
-    @expectedFailureLinux # FIXME: This needs to be root-caused.  It looks like the DWARF info is anticipating the derived class assignment.
     @python_api_test
     @dwarf_test
     def test_get_dynamic_vals_with_dwarf(self):
Index: test/python_api/lldbutil/process/TestPrintStackTraces.py
===================================================================
--- test/python_api/lldbutil/process/TestPrintStackTraces.py
+++ test/python_api/lldbutil/process/TestPrintStackTraces.py
@@ -18,7 +18,6 @@
         # Find the line number to break inside main().
         self.line = line_number('main.cpp', '// Set break point at this line.')
 
-    @expectedFailureLinux # llvm.org/pr15415 -- partial stack trace in thread 1 (while stopped inside a read() call)
     @python_api_test
     def test_stack_traces(self):
         """Test SBprocess and SBThread APIs with printing of the stack traces."""
Index: test/python_api/value_var_update/TestValueVarUpdate.py
===================================================================
--- test/python_api/value_var_update/TestValueVarUpdate.py
+++ test/python_api/value_var_update/TestValueVarUpdate.py
@@ -19,7 +19,6 @@
         self.setTearDownCleanup(dictionary=self.d)
         self.do_test()
 
-    @expectedFailureLinux # non-core functionality, need to reenable and fix later (DES 2014.11.07)
     @expectedFailureFreeBSD("llvm.org/pr21620 GetValueDidChange() wrong")
     @python_api_test
     @dwarf_test

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6910.17959.patch
Type: text/x-patch
Size: 4998 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150110/f4e29674/attachment.bin>