[Lldb-commits] [PATCH] Enhance the Pipe interface for better portability

[Zachary Turner]

I went ahead and updated the Posix side to conform to the base interface.  I compiled on MacOSX and there were no errors.  There should be no functionality change here, so this patch is actually probably ok to go in as-is.  However, a few methods are still unimplemented.  These are all new methods that didn't exist before, so having them unimplemented shouldn't cause anything to break that was previously working.  They are in PipePosix.cpp, and should be obvious by inspecting the patch.

Hopefully Oleksiy can fill out these stubs in a followup patch, but I think this patch is ready to go in after review.


http://reviews.llvm.org/D6686

Files:
  include/lldb/Host/Pipe.h
  include/lldb/Host/PipeBase.h
  include/lldb/Host/posix/PipePosix.h
  include/lldb/Host/windows/PipeWindows.h
  lldb.xcodeproj/project.pbxproj
  source/Host/posix/ConnectionFileDescriptorPosix.cpp
  source/Host/posix/PipePosix.cpp
  source/Host/windows/PipeWindows.cpp
  source/Interpreter/ScriptInterpreterPython.cpp
  source/Target/Process.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6686.17358.patch
Type: text/x-patch
Size: 32933 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141216/0b033396/attachment.bin>