[Lldb-commits] [PATCH] Fix compilation faliures for x64 visual studio 2013 build

Aidan Dodds Aidan at codeplay.com
Wed Dec 17 06:59:10 PST 2014

Hi zturner, clayborg, emaste, domipheus,

The visual studio 2013 x64 build is failing due to some type differences between 32bit and 64bit builds.

The CONTEXT structure used in RegisterContextWindows_x86 changes its fields based on the build.
Currently I have used #ifdefs to alternate between the different registers for each build, is this an acceptable solution?

It seems however that HostThreadWindows is largely 32bit specific, so should there rather be a dedicated x64 version?

In HostThreadWindows its seems that ULONG_PTR also changes its size based on the machine type, however the argument for ExitThread() doesnt change in a simmilar way.
I have created a proxy function to wrap ExitThread() so it can again be used as a function pointer.

If these changes are acceptable, would someone be able to commit these fixes since I dont currently have commit access.




-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6704.17392.patch
Type: text/x-patch
Size: 3970 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141217/f8831691/attachment.bin>

More information about the lldb-commits mailing list