[Lldb-commits] Fwd: [PATCH] lldb-mi: print the prompt after commands

Ilia K ki.stfu at gmail.com
Wed Dec 17 07:04:11 PST 2014


It seems my previous message wasn't included in the mailing list. See it
below, please.


---------- Forwarded message ----------
From: Ilia K <ki.stfu at gmail.com>
Date: Tue, Dec 16, 2014 at 3:43 PM
Subject: [Lldb-commits] [PATCH] lldb-mi: print the prompt after commands
To: "Abid, Hafiz" <Hafiz_Abid at mentor.com>, "lldb-commits at cs.uiuc.edu" <
lldb-commits at cs.uiuc.edu>


This patch contains the fix of prompt's printing after commands in MI mode.

Previously the prompt was printed in MICmnStreamStdin::MonitorStdin before
::fgets() was called what was wrong because lldb-mi has separate thread to
read user's input. Therefore prompt was printed after each user's input
even if command hadn't been executed. In this patch prompt is printed after
the command is executed.
Also, early the prompt was declared in different places. I have refactored
this code and have moved it to CMICmnStreamStdout::WritePrompt function.
And finally I added checks for my improvements in TestMiBreakpoint test.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141217/7ff8182d/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lldbmi_fix_prompt_gdb.v7.patch
Type: application/octet-stream
Size: 15754 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141217/7ff8182d/attachment.obj>

More information about the lldb-commits mailing list