[Lldb-commits] [PATCH] Documentation for test timeout

Zachary Turner zturner at google.com
Mon Dec 15 16:26:45 PST 2014


Looks ok to me, but in the (hopefully near) future I would like to see LLDB_TEST_TIMEOUT change from an environment variable to an argument to dotest.py.  Correct use of environment variables requires having intimate knowledge of the code in order to use correctly, increasing the code complexity.  Having the value be a command line option means it's documented clearly for anyone just by running dotest.py --help


http://reviews.llvm.org/D6669

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list