[Lldb-commits] [lldb] r224170 - SyntheticChildrenFrontEnd::* should also be built when python is disabled

Keno Fischer kfischer at college.harvard.edu
Fri Dec 12 16:05:58 PST 2014


Author: kfischer
Date: Fri Dec 12 18:05:58 2014
New Revision: 224170

URL: http://llvm.org/viewvc/llvm-project?rev=224170&view=rev
Log:
SyntheticChildrenFrontEnd::* should also be built when python is disabled

Summary:
This moves
- SyntheticChildrenFrontEnd::CreateValueObjectFromExpression
- SyntheticChildrenFrontEnd::CreateValueObjectFromAddress
- SyntheticChildrenFrontEnd::CreateValueObjectFromData
outside the `#ifndef LLDB_DISABLE_PYTHON` since it doesn't seem to depend on python being available and indeed breaks the build when python is disabled.

Reviewers: granata.enrico

Subscribers: lldb-commits

Differential Revision: http://reviews.llvm.org/D6646

Modified:
    lldb/trunk/source/DataFormatters/TypeSynthetic.cpp

Modified: lldb/trunk/source/DataFormatters/TypeSynthetic.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/DataFormatters/TypeSynthetic.cpp?rev=224170&r1=224169&r2=224170&view=diff
==============================================================================
--- lldb/trunk/source/DataFormatters/TypeSynthetic.cpp (original)
+++ lldb/trunk/source/DataFormatters/TypeSynthetic.cpp Fri Dec 12 18:05:58 2014
@@ -63,6 +63,41 @@ CXXSyntheticChildren::GetDescription()
     return sstr.GetString();
 }
 
+lldb::ValueObjectSP
+SyntheticChildrenFrontEnd::CreateValueObjectFromExpression (const char* name,
+                                                            const char* expression,
+                                                            const ExecutionContext& exe_ctx)
+{
+    ValueObjectSP valobj_sp(ValueObject::CreateValueObjectFromExpression(name, expression, exe_ctx));
+    if (valobj_sp)
+        valobj_sp->SetSyntheticChildrenGenerated(true);
+    return valobj_sp;
+}
+
+lldb::ValueObjectSP
+SyntheticChildrenFrontEnd::CreateValueObjectFromAddress (const char* name,
+                                                         uint64_t address,
+                                                         const ExecutionContext& exe_ctx,
+                                                         ClangASTType type)
+{
+    ValueObjectSP valobj_sp(ValueObject::CreateValueObjectFromAddress(name, address, exe_ctx, type));
+    if (valobj_sp)
+        valobj_sp->SetSyntheticChildrenGenerated(true);
+    return valobj_sp;
+}
+
+lldb::ValueObjectSP
+SyntheticChildrenFrontEnd::CreateValueObjectFromData (const char* name,
+                                                      const DataExtractor& data,
+                                                      const ExecutionContext& exe_ctx,
+                                                      ClangASTType type)
+{
+    ValueObjectSP valobj_sp(ValueObject::CreateValueObjectFromData(name, data, exe_ctx, type));
+    if (valobj_sp)
+        valobj_sp->SetSyntheticChildrenGenerated(true);
+    return valobj_sp;
+}
+
 #ifndef LLDB_DISABLE_PYTHON
 
 ScriptedSyntheticChildren::FrontEnd::FrontEnd(std::string pclass, ValueObject &backend) :
@@ -111,39 +146,4 @@ ScriptedSyntheticChildren::GetDescriptio
     return sstr.GetString();
 }
 
-lldb::ValueObjectSP
-SyntheticChildrenFrontEnd::CreateValueObjectFromExpression (const char* name,
-                                                            const char* expression,
-                                                            const ExecutionContext& exe_ctx)
-{
-    ValueObjectSP valobj_sp(ValueObject::CreateValueObjectFromExpression(name, expression, exe_ctx));
-    if (valobj_sp)
-        valobj_sp->SetSyntheticChildrenGenerated(true);
-    return valobj_sp;
-}
-
-lldb::ValueObjectSP
-SyntheticChildrenFrontEnd::CreateValueObjectFromAddress (const char* name,
-                                                         uint64_t address,
-                                                         const ExecutionContext& exe_ctx,
-                                                         ClangASTType type)
-{
-    ValueObjectSP valobj_sp(ValueObject::CreateValueObjectFromAddress(name, address, exe_ctx, type));
-    if (valobj_sp)
-        valobj_sp->SetSyntheticChildrenGenerated(true);
-    return valobj_sp;
-}
-
-lldb::ValueObjectSP
-SyntheticChildrenFrontEnd::CreateValueObjectFromData (const char* name,
-                                                      const DataExtractor& data,
-                                                      const ExecutionContext& exe_ctx,
-                                                      ClangASTType type)
-{
-    ValueObjectSP valobj_sp(ValueObject::CreateValueObjectFromData(name, data, exe_ctx, type));
-    if (valobj_sp)
-        valobj_sp->SetSyntheticChildrenGenerated(true);
-    return valobj_sp;
-}
-
 #endif // #ifndef LLDB_DISABLE_PYTHON





More information about the lldb-commits mailing list