[Lldb-commits] [PATCH] new lldb-mi token test and cleanup

[Abid, Hafiz]

Hi Dawn,
This looks good to me. Just one question. You said that you removed the prompt check. So bad path test can be enabled. But the check for prompt is still there in the patch as show below and I has to remove this for test to work. I believe this was just an oversight but wanted to get confirmation before I commit this patch.

> -                child.expect_exact(prompt)
> +                child.expect_exact(prompt) #FIXME: no prompt after error

Regards,
Abid

> -----Original Message-----
> From: dawn at burble.org [mailto:dawn at burble.org]
> Sent: 25 November 2014 22:23
> To: Abid, Hafiz
> Cc: Vince Harron; Zachary Turner; lldb-commits at cs.uiuc.edu
> Subject: Re: [Lldb-commits] [PATCH] new lldb-mi token test and cleanup
> 
> To all: points taken on the platform specificity.  Thanks.
> 
> Abid,
> 
> Thank you for committing the tests.  The attached patch adds the token test
> you asked for as well as other cleanup.  Please review and commit?
> 
> summary of changes:
> 
>     Cleanup: Use "line_number" API instead of hardcoded source lines
>            Combine child.sendline with previous child.send command.
>     test_lldbmi_tokens: Add test for MI tokens.
>     test_lldbmi_badpathexe: Remove check for prompt so test for
> 	   bad path can be enabled.
> 
> Thanks,
>     -Dawn
> 
> On Tue, Nov 25, 2014 at 10:44:55AM +0000, Abid, Hafiz wrote:
> > I have enabled the tests for all hosts apart from
> ???test_lldbmi_interrupt??? which was giving error to me on Linux. I will see
> if I can figure out why it is failing there. The patch is committed.
> >
> > Regards,
> > Abid
> >
> > From: Vince Harron [mailto:vharron at google.com]
> > Sent: 25 November 2014 08:08
> > To: Zachary Turner
> > Cc: lldb-commits at cs.uiuc.edu; dawn at burble.org; Abid, Hafiz
> > Subject: Re: [Lldb-commits] [PATCH] add tests for lldb-mi
> >
> > Yes, please enable tests if they _should_ work on other platforms.