[Lldb-commits] [PATCH] Fix several test failures on Linux/FreeBSD caused by compiler configuration and invalid environment

[Oleksiy Vyalov]

Please see my comment.

Thank you!

================
Comment at: test/lang/c/shared_lib/TestSharedLib.py:62-63
@@ -64,1 +61,4 @@
+        else:
+            # Register our shared libraries for remote targets so they get automatically uploaded
+            environment = self.registerSharedLibrariesWithTarget(target, self.shlib_names)
 
----------------
emaste wrote:
> Will we need this on FreeBSD and Linux later on? I.e., do we need to append this to the environment?
Presumably we may move Linux/BSD logic from here to lldbtest.py (https://github.com/llvm-mirror/lldb/blob/master/test/lldbtest.py#L1672) - as TODO suggests to expand this function with support for other platforms.
For now, we still need this environment variable to allow dynamic loader to find the shared library .

http://reviews.llvm.org/D6392