[Lldb-commits] [PATCH] add tests for lldb-mi

[Vince Harron]

Yes, please enable tests if they _should_ work on other platforms.
 On Nov 24, 2014 11:27 PM, "Zachary Turner" <zturner at google.com> wrote:

> On Mon Nov 24 2014 at 11:03:58 PM <dawn at burble.org> wrote:
>
>> Thank you for your review!
>>
>> On Mon, Nov 24, 2014 at 11:18:40AM +0000, Abid, Hafiz wrote:
>> > Hi Dawn,
>> > I had a quick look at the tests and I think those will be useful
>> addition. I have
>> > the following questions though.
>> >
>> > 1. I am wondering why have you restricted tests to darwin only?
>>
>> because I only tested on OSX and didn't want to break any builds.
>>
>
>  This is an understandable mentality, but I think for the greater good we
> should have a policy of having all tests enabled for all platforms, unless
> it exercises a specific feature of a platform which is known to not exist
> or not work the same way on other platforms.
>
> A debugger has the unfortunate property that it is OS-specific by nature,
> and generally someone working on a particular platform either doesn't have
> access to or doesn't know anything about other platforms.  As a result,
> it's easy to get into a situation where everyone only writes tests for
> their own platform, or writes a feature in a way that is specific to their
> platform.
>
> But I think it's important to remain vigilant against this.  We have build
> bots for most platforms, the notable exception being Windows, which I'm
> actively working on fixing, although it's a lot of work for one person to
> do so it will take some more time.
>
> In the mean time, you should not restrict tests unless you have a specific
> reason, and if it breaks something you should either
>
> a) revert your change and attempt to fix the broken tests before
> resubmitting (sometimes you can do this by yourself, just by looking at the
> failure and guessing why this might be broken on other platforms)
>
> b) run the test on other platforms yourself (wherever possible) and fix
> the errors
>
> c) ask for help.
>
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141125/1066e9c2/attachment.html>