[Lldb-commits] [PATCH] add tests for lldb-mi

[Abid, Hafiz]

Hi Dawn,
I had a quick look at the tests and I think those will be useful addition. I have
the following questions though.

1. I am wondering why have you restricted tests to darwin only? I have tried them
on Linux and they seem to work. Although 'interrupt' test gave a timeout error. 
I will try to figure out why that test fails on Linux.

2. Why you are logging input/output is each test. Can we do without them?

3. It will be useful to also test command which have some initial digits like
   25-insert-break as IDEs sends MI command in that pattern.

4. I think it will be useful to test '-gdb-exit' instead of 'quit'. Although 
   there is a little bug in lldb-mi for this case. I will send a fix for it.

5. I think we have the copyright notice in the C files although I am not sure 
   of the policies.

If there are no more comments from community then I think the tests are good 
enough to be committed. The things that I mentioned above can be fixed with time.
If you don't have commit access then please let me know. I will commit them for
you.

Thanks,
Abid


> -----Original Message-----
> From: lldb-commits-bounces at cs.uiuc.edu [mailto:lldb-commits-
> bounces at cs.uiuc.edu] On Behalf Of dawn at burble.org
> Sent: 22 November 2014 03:09
> To: lldb-commits at cs.uiuc.edu
> Subject: Re: [Lldb-commits] [PATCH] add tests for lldb-mi
> 
> Has anyone had a chance to review this patch yet?  Any reason not commit
> it?
> 
> Thanks,
> -Dawn
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits