[Lldb-commits] [PATCH] Add some comments better documenting some fields of RegisterInfo and RegisterSet

[Zachary Turner]

Hi clayborg,

No code change here. Putting this up for review to make sure you agree with the comments as written here.

One question: Will value_regs ever contain more than a single value? Example:

x86-64:
value_regs(ah) = { rax, LLDB_INVALID_REGNUM }
value_regs(al) = { rax, LLDB_INVALID_REGNUM }
value_regs(ax) = { rax, LLDB_INVALID_REGNUM }
value_regs(eax) = { rax, LLDB_INVALID_REGNUM }
value_regs(rax) = nullptr

x86:
value_regs(ah) = { eax, LLDB_INVALID_REGNUM }
value_regs(al) = { eax, LLDB_INVALID_REGNUM }
value_regs(ax) = { eax, LLDB_INVALID_REGNUM }
value_regs(eax) = nullptr

When would value_regs ever contain more than one value?

http://reviews.llvm.org/D6368

Files:
  include/lldb/lldb-private-types.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6368.16521.patch
Type: text/x-patch
Size: 3200 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141122/d6d96665/attachment.bin>