[Lldb-commits] [PATCH] Add test for denied process attach by pid and fix found bugs in Process/ProcessPOSIX.cpp

Oleksiy Vyalov ovyalov at google.com
Tue Nov 18 17:38:37 PST 2014


I reworked test according to Ed's suggestion with fork to make the test to cover OSX, Linux and FreeBSD.
Along the way FreeBSD/ProcessMonitor bug was discovered which led LLDB to hang when Attach fails - fixed this.
Checked against OSX 10.9.5, Ubuntu 14.0.4 and FreeBSD 10 - no regressions found.

Please take another look.

http://reviews.llvm.org/D6240

Files:
  source/Plugins/Process/FreeBSD/ProcessMonitor.cpp
  source/Plugins/Process/FreeBSD/ProcessMonitor.h
  source/Plugins/Process/POSIX/ProcessPOSIX.cpp
  source/Target/Process.cpp
  test/functionalities/process_attach/attach_denied/Makefile
  test/functionalities/process_attach/attach_denied/TestAttachDenied.py
  test/functionalities/process_attach/attach_denied/main.cpp
  test/lang/objc/objc-runtime-ivars/Makefile
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6240.16359.patch
Type: text/x-patch
Size: 7225 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141119/d92545f2/attachment.bin>


More information about the lldb-commits mailing list