[Lldb-commits] [PATCH] Change the way SWIG is found, and fixed a typo in OS detection

Ed Maste emaste at freebsd.org
Mon Nov 17 07:52:44 PST 2014


Overall seems like a good idea - one thing I don't understand is marked above.

This could be useful for FreeBSD as well, as the swig 2.0 package installs swig as `swig2` (or similar), and so `swig` is not found in the `PATH`.

================
Comment at: scripts/CMakeLists.txt:12
@@ -12,1 +11,3 @@
+	  DEPENDS ${SWIG_INPUTS}
+	  COMMAND ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/buildSwigWrapperClasses.py "--srcRoot=${LLDB_SOURCE_DIR}" "--targetDir=${CMAKE_CURRENT_BINARY_DIR}" "--cfgBldDir=${CMAKE_CURRENT_BINARY_DIR}" "--prefix=${CMAKE_BINARY_DIR}" "--swigDir=${SWIG_DIR}" "--swigExecutable=${SWIG_EXECUTABLE}" -m
 	  COMMENT "Python script building LLDB Python wrapper")  
----------------
I must be missing something -- I don't see how swigDir is used.

http://reviews.llvm.org/D6290






More information about the lldb-commits mailing list