[Lldb-commits] [lldb] r221809 - Update comments to reflect how the new methods ended up being written.

Jason Molenda jmolenda at apple.com
Wed Nov 12 11:49:58 PST 2014


Author: jmolenda
Date: Wed Nov 12 13:49:58 2014
New Revision: 221809

URL: http://llvm.org/viewvc/llvm-project?rev=221809&view=rev
Log:
Update comments to reflect how the new methods ended up being written.


Modified:
    lldb/trunk/include/lldb/Symbol/UnwindPlan.h

Modified: lldb/trunk/include/lldb/Symbol/UnwindPlan.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Symbol/UnwindPlan.h?rev=221809&r1=221808&r2=221809&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Symbol/UnwindPlan.h (original)
+++ lldb/trunk/include/lldb/Symbol/UnwindPlan.h Wed Nov 12 13:49:58 2014
@@ -295,25 +295,24 @@ public:
             m_cfa_type = cfa_type;
         }
 
-        // This should be used when GetCFAType() returns CFAIsRegisterPlusOffset
+        // If GetCFAType() is CFAIsRegisterPlusOffset, add GetCFAOffset to the reg value to get CFA value
+        // If GetCFAType() is CFAIsRegisterDereferenced, dereference the addr in the reg to get CFA value
         uint32_t
         GetCFARegister () const
         {
             return m_cfa_reg_num;
         }
         
-        // This should be used when GetCFAType() is set to CFAIsRegisterPlusOffset
         void
         SetCFARegister (uint32_t reg_num);
 
-        // This should be used when GetCFAType() returns CFAIsRegisterPlusOffset
+        // This should not be used when GetCFAType() is CFAIsRegisterDereferenced; will return 0 in that case.
         int32_t
         GetCFAOffset () const
         {
             return m_cfa_offset;
         }
 
-        // This should be used when GetCFAType() is set to CFAIsRegisterPlusOffset
         void
         SetCFAOffset (int32_t offset)
         {





More information about the lldb-commits mailing list