[Lldb-commits] [PATCH] Implement software breakpoints for arm in Linux platform.

Jason Molenda jmolenda at apple.com
Tue Oct 21 18:18:37 PDT 2014


Stephane, this looks good to me but I'm not personally involved with the PlatformLinux.  In debugserver we're using the bytes {0xfe, 0xde, 0xff, 0xe7} for arm and {0xfe, 0xde} for thumb - but if the ARM ARM recommends the byte sequences you've used here, that's probably for the best.

fwiw you might want to set up an account at http://reviews.llvm.org/ - it's a pretty useful system to make sure that patches are tracked, comments and revisions are recorded, assignment to people for review & signoff, to when the change has been finally committed.


> On Oct 21, 2014, at 1:26 PM, Stephane Sezer <sas at fb.com> wrote:
> 
> source/Plugins/Platform/Linux/PlatformLinux.cpp | 28 +++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> This is part of the linux/arm support for LLDB.
> 
> 
> 
> -- 
> Stephane Sezer
> 
> <0001-Implement-software-breakpoints-for-arm-in-Linux-plat.patch>_______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits





More information about the lldb-commits mailing list