[Lldb-commits] [PATCH] Compiler args patch resubmission

Alex Pepper apepper at blueshiftinc.com
Wed Oct 15 14:21:19 PDT 2014


Hi tfiala, emaste,

Resubmission of Tong's compiler args patch (reviews.llvm.org/D5472) with minor modifications.

This patch differs from Tong's original change in how it attempts to match option argument strings for quotation removal after parsing.  The original change compared strings which could fail when more than one string matched, this version checks the string pointer returned from the parser with the original string in the argv array.  This change was driven by the issue reported in Bug 21190.  Ideally this would be resolved by writing a different options parser but until that happens this is a workable solution.

http://reviews.llvm.org/D5806

Files:
  include/lldb/Expression/ClangExpressionParser.h
  include/lldb/Target/Target.h
  source/Expression/ClangExpressionParser.cpp
  source/Expression/ClangFunction.cpp
  source/Expression/ClangUserExpression.cpp
  source/Expression/ClangUtilityFunction.cpp
  source/Interpreter/Args.cpp
  source/Target/Target.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5806.14961.patch
Type: text/x-patch
Size: 9341 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141015/783945e3/attachment.bin>


More information about the lldb-commits mailing list