[Lldb-commits] [lldb] r219620 - Don't lock the IOHandlerList::m_mutex in Debugger::RunIOHandler(...) since if a process is resumed or halted, it will try to push/pop the process IOHandler and it will deadlock.

Greg Clayton gclayton at apple.com
Mon Oct 13 09:54:26 PDT 2014


Author: gclayton
Date: Mon Oct 13 11:54:26 2014
New Revision: 219620

URL: http://llvm.org/viewvc/llvm-project?rev=219620&view=rev
Log:
Don't lock the IOHandlerList::m_mutex in Debugger::RunIOHandler(...) since if a process is resumed or halted, it will try to push/pop the process IOHandler and it will deadlock.

<rdar://problem/18610852>


Modified:
    lldb/trunk/source/Core/Debugger.cpp

Modified: lldb/trunk/source/Core/Debugger.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/Debugger.cpp?rev=219620&r1=219619&r2=219620&view=diff
==============================================================================
--- lldb/trunk/source/Core/Debugger.cpp (original)
+++ lldb/trunk/source/Core/Debugger.cpp Mon Oct 13 11:54:26 2014
@@ -914,7 +914,6 @@ Debugger::GetTopIOHandlerControlSequence
 void
 Debugger::RunIOHandler (const IOHandlerSP& reader_sp)
 {
-    Mutex::Locker locker (m_input_reader_stack.GetMutex());
     PushIOHandler (reader_sp);
     
     IOHandlerSP top_reader_sp = reader_sp;





More information about the lldb-commits mailing list