[Lldb-commits] [lldb] r218325 - Fix up the HostThread interface, making the interface simpler.

[Ed Maste]

On 30 September 2014 14:44, Todd Fiala <tfiala at google.com> wrote:
>
> Oh I think I see what's going on.
>
> For Android, Tong had to add some complete pathing to files.  He did not realize that FreeBSD/Linux play header file directory tom-foolery to give each the appropriate view of ProcessMonitor.h (there are two --- one for FreeBSD, one for Linux).  I think he hard coded the Linux path when FreeBSD needs the FreeBSD one.
>
> I'll get that addressed.

I committed the naive fix in r218762 and FreeBSD now builds and
(locally) passes the test suite again.

We'll still need to take a look at a more holistic rework of the
POSIX/Linux/FreeBSD classes at some point.  We have a lot of code
that's just duplicated in the Linux and FreeBSD-specific ones, and
other code in the POSIX base class that's actually OS-specific.  I
hope that I can find some time to work on that along with the llgs
FreeBSD porting effort.