[Lldb-commits] [PATCH] Move ConnectionFileDescriptor to posix-subfolder in preparation for implementing on Windows

Zachary Turner zturner at google.com
Tue Sep 30 13:22:42 PDT 2014


Hi clayborg, jingham,

ConnectionFileDescriptor needs a different implementation on Windows and non-Windows platforms due to some fundamental differences.  This patch moves source\Core\ConnectionFileDescriptor.cpp to source\Core\posix\ConnectionFileDescriptorPosix.cpp, and similarly for the corresponding header file.  Then, the original ConnectionFileDescriptor.h is replaced with a new implementation that includes the platform specific header file.  

Currently this patch does not actually implement Windows' version of ConnectionFileDescriptor.  It only makes the organizational changes necessary for this to happen in a subsequent patch.  As such, with this patch, Windows will actually be compiling source\Core\posix\ConnectionFileDescriptor.cpp.  When the windows version of CFD goes in, the CMake will be updated accordingly to compile the windows CFD.

This patch contains no functional changes, only code move.

http://reviews.llvm.org/D5548

Files:
  include/lldb/Core/ConnectionFileDescriptor.h
  include/lldb/Core/posix/ConnectionFileDescriptorPosix.h
  lldb.xcodeproj/project.pbxproj
  source/Core/CMakeLists.txt
  source/Core/ConnectionFileDescriptor.cpp
  source/Core/posix/ConnectionFileDescriptorPosix.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5548.14244.patch
Type: text/x-patch
Size: 77431 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140930/60c9f7e6/attachment.bin>


More information about the lldb-commits mailing list