[Lldb-commits] [lldb] r218325 - Fix up the HostThread interface, making the interface simpler.

[Todd Fiala]

Oh I think I see what's going on.

For Android, Tong had to add some complete pathing to files.  He did not
realize that FreeBSD/Linux play header file directory tom-foolery to give
each the appropriate view of ProcessMonitor.h (there are two --- one for
FreeBSD, one for Linux).  I think he hard coded the Linux path when FreeBSD
needs the FreeBSD one.

I'll get that addressed.

On Tue, Sep 30, 2014 at 11:18 AM, Todd Fiala <tfiala at google.com> wrote:

> >> Todd is looking into them.
>
> Yep - looking at the FreeBSD build at TOT.  I've got a couple interviews
> to conduct so might not get this wrapped up until late afternoon, but I am
> building and starting to investigate now.
>
> FreeBSD and Linux both overlap heavily in the ProcessMonitor/ProcessPOSIX
> space, so we might have Linux changes that broke the FreeBSD usage.  Quite
> possibly introduced by me or my community submissions over the last few
> weeks.
>
> -Todd
>
> On Tue, Sep 30, 2014 at 10:52 AM, Zachary Turner <zturner at google.com>
> wrote:
>
>> The errors due to my patch have been addressed.  There's two more that
>> appear unrelated to my patch, Todd is looking into them.
>>
>> On Tue, Sep 30, 2014 at 8:01 AM, Zachary Turner <zturner at google.com>
>> wrote:
>>
>>> Will have a look when I get in later this morning.
>>>
>>> On Tue, Sep 30, 2014 at 6:00 AM, Ed Maste <emaste at freebsd.org> wrote:
>>>
>>>> On 23 September 2014 14:32, Zachary Turner <zturner at google.com> wrote:
>>>> > Author: zturner
>>>> > Date: Tue Sep 23 13:32:09 2014
>>>> > New Revision: 218325
>>>> >
>>>> > URL: http://llvm.org/viewvc/llvm-project?rev=218325&view=rev
>>>> > Log:
>>>> > Fix up the HostThread interface, making the interface simpler.
>>>> >
>>>> > Reviewed by: Greg Clayton
>>>> > Differential Revision: http://reviews.llvm.org/D5417
>>>>
>>>> FreeBSD build has been broken for a week with this change.  Zach, can
>>>> you please have a look at applying the same changes there?
>>>>
>>>
>>>
>>
>
>
> --
> Todd Fiala | Software Engineer | tfiala at google.com
>
>


-- 
Todd Fiala | Software Engineer | tfiala at google.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140930/a3ed0155/attachment.html>