[Lldb-commits] [PATCH] Make llgs build on Android. No functionality changes.

Jim Ingham jingham at apple.com
Thu Sep 25 16:23:15 PDT 2014

I don't have time to look at this right now, but that's an awful lot of #ifndef __ANDROID__ in places I wouldn't really expect these defines.  Particularly the ones that deal with the IOHandlerEditLine.  Either you're building stuff for llgs that you don't really need to (why does it need the command interpreter) or we really need a non-interactive configuration for the command interpreter that substitutes the EditLine I/O handler with one that is not interactive...  Anyway, that part does seem ugly to me.

Also one of the uses of __ANDROID__ is to not include some python goo, but there's already a "build without python" define for that purpose.



More information about the lldb-commits mailing list