[Lldb-commits] [PATCH] Fix up the HostThread interface
zturner at google.com
Tue Sep 23 09:33:40 PDT 2014
ping. does this patch address your concerns satisfactorily based on our
discussion a few days ago?
On Fri, Sep 19, 2014 at 3:06 PM, Zachary Turner <zturner at google.com> wrote:
> +greg. Any chance you guys are willing to create Phabricator accounts?
> Even if you don't use it to submit reviews, it's nice to just be able to
> type your name into the website and have it include you in the original
> email automatically.
> On Fri, Sep 19, 2014 at 1:51 PM, Zachary Turner <zturner at google.com>
>> * Removes GetState / SetState
>> * Adds a method IsJoinable()
>> There is no need for a distinction between IsHandleValid and
>> IsThreadRunning, because even if a thread has run to completion, you are
>> still required to Join on it. So a better function simply checks whether a
>> thread is joinable. This is equivalent to checking if the handle is valid,
>> because the Join() operation can reset the handle to an invalid handle
>> after it has been performed.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits