[Lldb-commits] [PATCH] Fix up the HostThread interface

Zachary Turner zturner at google.com
Fri Sep 19 13:51:53 PDT 2014


* Removes GetState / SetState
* Adds a method IsJoinable() 

There is no need for a distinction between IsHandleValid and IsThreadRunning, because even if a thread has run to completion, you are still required to Join on it.  So a better function simply checks whether a thread is joinable.  This is equivalent to checking if the handle is valid, because the Join() operation can reset the handle to an invalid handle after it has been performed.

http://reviews.llvm.org/D5417

Files:
  include/lldb/Core/Debugger.h
  include/lldb/Host/HostNativeThreadBase.h
  include/lldb/Host/HostThread.h
  include/lldb/Host/posix/HostThreadPosix.h
  include/lldb/Target/Process.h
  include/lldb/lldb-private-enumerations.h
  source/Core/Communication.cpp
  source/Core/Debugger.cpp
  source/Host/common/HostNativeThreadBase.cpp
  source/Host/common/HostThread.cpp
  source/Host/posix/HostThreadPosix.cpp
  source/Host/windows/HostThreadWindows.cpp
  source/Plugins/Process/Linux/NativeProcessLinux.cpp
  source/Plugins/Process/Linux/ProcessMonitor.cpp
  source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  source/Target/Process.cpp
  tools/lldb-gdbserver/lldb-gdbserver.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5417.13889.patch
Type: text/x-patch
Size: 23440 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140919/34376792/attachment.bin>


More information about the lldb-commits mailing list