[Lldb-commits] [PATCH] lldb more verbose "invalid frame" error

[Jason Molenda]

Ah, there were a couple of emails that I don't see on lldb-commits, not sure if they're delayed, or if I forgot to cc the list while at work.

I thought about this a bit more.  Right now if you start lldb and try to reg read pc, you get an error about there being no frame.  This is the "smallest" thing that you need to fulfill the request.  But of course you also don't have the Thread (next bigger thing), or a Process (next bigger) or even a Target (biggest).

Maybe we should change it so the behavior is

% lldb
(lldb) reg read pc
error: invalid target, create a target using the 'target create' command


instead of listing all of the things that the command needs (frame, thread, process, target)?



On Sep 18, 2014, at 7:49 PM, Jason Molenda <jmolenda at apple.com> wrote:

> I applied the patch and was going to commit it, then I realized I don't clearly understand what behavior we're fixing.  e.g. these commands all report a reasonable error msg when a thread/process/frame is missing before the patch is applied.
> 
> % lldb
> (lldb) f
> error: invalid thread
> (lldb) bt
> error: invalid process
> (lldb) reg read pc
> error: invalid frame
> (lldb) c
> error: invalid process
> (lldb) 
> 
> 
> 
>> On Sep 18, 2014, at 9:09 AM, Todd Fiala <tfiala at google.com> wrote:
>> 
>> Jason, do you want to submit this or do you want me to run it through over
>> here?
>> 
>> http://reviews.llvm.org/D5374
>> 
>> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits