[Lldb-commits] [PATCH] [compiler-rt] ASan debugging API for report info extraction and locating addresses

Kuba Brecka kuba.brecka at gmail.com
Tue Sep 16 12:03:32 PDT 2014


>>! In D4527#33, @samsonov wrote:
>>> Why not internal_strncpy(descr->name, vars[i].name_pos, Min(descr->name_size - 1, vars[i].name_len)) ?
>> Because that would not write \0 after the string (we're copying just a part of the string pointed to by vars[i].name_pos). So I would have to memset the whole buffer to zero before. Should I do that, instead of the strncat? (The strncat is also used in asan_report.cc:436).
> Right, let's keep strncat here then.

Ok. So, are you fine with how the patch looks like now?

http://reviews.llvm.org/D4527






More information about the lldb-commits mailing list