[Lldb-commits] [PATCH] Print a newline before exiting the driver.

[Stephane Sezer]

This should be slightly better.



On Sep 15, 2014, at 9:52 AM, Todd Fiala <tfiala at google.com> wrote:

> That'd be great, thanks!
>
> On Mon, Sep 15, 2014 at 9:48 AM, Stephane Sezer <sas at fb.com> wrote:
> Hey Todd,
>
> I see what you are talking about. If someone exits the debugger by typing `exit` then there is an empty new-line being printed. The reason why I wrote this patch in the first place is because I’m used to exit the debugger with ^D instead, which results in the shell prompt being printed right after the debugger prompt (lldb).
>
> I think I could rework this patch to print the newline only on ^D instead of printing it all the time when we exit.
>
> On Sep 15, 2014, at 9:21 AM, Todd Fiala <tfiala at google.com> wrote:
>
> > Hey Stephane,
> >
> > For typical debugger usage, this is generally adding an extra blank line, which feels a little awkward.  Could you consider reworking this perhaps to only add the extra \n if we're ending mid-line?  Or fix the systems that are ending mid-line and have them add the \n when shutting down (e.g. inferior process stdout/stderr)?
> >
> > I found when I played with it a while, the extra line made me feel like my program was outputting something I wasn't expecting, or that I'm somehow missing something from the debugger.
> >
> > -Todd
> >
> > On Wed, Sep 10, 2014 at 1:45 PM, Stephane Sezer <sas at fb.com> wrote:
> > This prevents messing up the shell's prompt.
> >
> >
> > _______________________________________________
> > lldb-commits mailing list
> > lldb-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
> >
> >
> >
> >
> > --
> > Todd Fiala |   Software Engineer |     tfiala at google.com |     650-943-3180
> >
>
>
>
>
> --
> Todd Fiala |   Software Engineer |      tfiala at google.com |      650-943-3180

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140915/a485b787/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Print-a-newline-before-exiting-the-driver.patch
Type: application/octet-stream
Size: 1818 bytes
Desc: 0001-Print-a-newline-before-exiting-the-driver.patch
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140915/a485b787/attachment.obj>