[Lldb-commits] [PATCH] Handle ARM ELF symbols properly.
tfiala at google.com
Mon Sep 15 09:38:37 PDT 2014
Part 1 committed here:
Transmitting file data .
Committed revision 217782.
Stephane - it would be great if you could add a unit test to verify those
symbols are getting stripped. Let me know if you need help figuring out
how the unit tests work.
Looking at Part 2 now.
On Wed, Sep 10, 2014 at 12:55 PM, Stephane Sezer <sas at fb.com> wrote:
> Re-sending these, as the first email didn’t reach the mailing list for
> some reason.
> On Sep 9, 2014, at 5:27 PM, Stephane Sezer <sas at fb.com> wrote:
> > Two patches here:
> > [PATCH 1/2] Skip $t* and $a* symbols in ObjectFileELF.
> > ELF objects contain marker symbols to differentiate between ARM and
> > THUMB functions. Instead of storing them internally and having garbage
> > show up when symbols are searched for by the user, we can just skip them
> > and not store them at all, as we never actually need them.
> > [PATCH 2/2] Store the thumbness of a function in symbol flags.
> > This allows us to fixup the address of the symbol as soon as we parse it
> > so that lldb is not confused thinking there are two different symbols in
> > the binary (one with the thumb bit, one without). Also, differentiating
> > between THUMB and ARM symbols allows the debugger to place the right
> > type of breakpoint.
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits