[Lldb-commits] [lldb] r217375 - DataFormatters: add missing function implementations

Saleem Abdulrasool compnerd at compnerd.org
Mon Sep 8 07:59:33 PDT 2014


Author: compnerd
Date: Mon Sep  8 09:59:33 2014
New Revision: 217375

URL: http://llvm.org/viewvc/llvm-project?rev=217375&view=rev
Log:
DataFormatters: add missing function implementations

This adds a definition for the TypeValidatorImpl_CXX destructor.  Because the
destructor is first virtual method, and declared out-of-line, it also serves as
the key function.  Since no definition was present, no virtual table for
TypeValidatorImpl_CXX was emitted, which results in link failures due to
references to undefined symbols.

Also add a definition for a TypeValidatorImpl contructor which was declared
out-of-line and referenced in a constructor for TypeValidatorImpl_CXX.

Modified:
    lldb/trunk/source/DataFormatters/TypeValidator.cpp

Modified: lldb/trunk/source/DataFormatters/TypeValidator.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/DataFormatters/TypeValidator.cpp?rev=217375&r1=217374&r2=217375&view=diff
==============================================================================
--- lldb/trunk/source/DataFormatters/TypeValidator.cpp (original)
+++ lldb/trunk/source/DataFormatters/TypeValidator.cpp Mon Sep  8 09:59:33 2014
@@ -20,6 +20,12 @@
 using namespace lldb;
 using namespace lldb_private;
 
+TypeValidatorImpl::TypeValidatorImpl(const Flags &flags)
+    : m_flags(flags)
+    , m_my_revision(0)
+{
+}
+
 TypeValidatorImpl::ValidationResult
 TypeValidatorImpl::Success ()
 {
@@ -39,6 +45,10 @@ TypeValidatorImpl_CXX::TypeValidatorImpl
 {
 }
 
+TypeValidatorImpl_CXX::~TypeValidatorImpl_CXX()
+{
+}
+
 TypeValidatorImpl::ValidationResult
 TypeValidatorImpl_CXX::FormatObject (ValueObject *valobj) const
 {





More information about the lldb-commits mailing list