[Lldb-commits] [PATCH] fix lldb for changes to MachO version_min_command

Todd Fiala tfiala at google.com
Thu Sep 4 12:42:29 PDT 2014


I tested on Linux and MacOSX.  Since the tests are coming back clean and it
is fixing a build error, I'm going to go ahead and check this in.  Feel
free to revise as needed if it's not quite right.

Checked in as r217185.  Looks to be the change for tracking llvm r217172.

-Todd


On Thu, Sep 4, 2014 at 11:23 AM, Todd Fiala <tfiala at google.com> wrote:

> Does this look about right?  I get build errors on Linux and MacOSX
> without this change:
>
> diff --git a/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
> b/source/Plugins/ObjectFile/Mach-O/ObjectFi
> index 8d7fe04..67be5a5 100644
> --- a/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
> +++ b/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
> @@ -5026,9 +5026,9 @@ ObjectFileMachO::GetSDKVersion(uint32_t *versions,
> uint32_t num_versions)
>              {
>                  if (m_data.GetU32 (&offset, &lc.version, (sizeof(lc) /
> sizeof(uint32_t)) - 2))
>                  {
> -                    const uint32_t xxxx = lc.reserved >> 16;
> -                    const uint32_t yy = (lc.reserved >> 8) & 0xffu;
> -                    const uint32_t zz = lc.reserved  & 0xffu;
> +                    const uint32_t xxxx = lc.sdk >> 16;
> +                    const uint32_t yy = (lc.sdk >> 8) & 0xffu;
> +                    const uint32_t zz = lc.sdk & 0xffu;
>                      if (xxxx)
>                      {
>                          m_sdk_versions.push_back(xxxx);
> --
> Todd Fiala | Software Engineer |  tfiala at google.com |  650-943-3180
>



-- 
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140904/f6f6b264/attachment.html>


More information about the lldb-commits mailing list