[Lldb-commits] [PATCH] lldb more on register context arm64

Jason Molenda jmolenda at apple.com
Tue Sep 2 13:25:55 PDT 2014


Yeah, sorry for not looking more closely at the patch earlier.

As to my "so we're going to call RegisterValue::SetUInt64 on that -- I don't see where we'd recognize we only want the lower 32 bits and return those" comment, we may just be lucking out when the target / host are both little endian.  When we ask for w0, we stuff the full 64-bit value of x0 in the RegisterValue object - the RegisterValue object knows that w0 is 32-bits and so it grabs the first 32-bits of the 8-byte data buffer and that happens to be the lower 32-bits of x0 in BE order.  So it works out but it's one of those sneaky problems to find when we're trying to run lldb on a BE PPC system or something. :)

http://reviews.llvm.org/D5089






More information about the lldb-commits mailing list