[Lldb-commits] [lldb] r216238 - Add missing HostInfo::Initialize() in llgs.

[Todd Fiala]

There might be an issue there.

PluginManager uses the file system initialization.  But I think Debugger
depends on HostInfo being initialized first.

I'll look and see if I can detangle that.


On Tue, Aug 26, 2014 at 11:43 AM, Todd Fiala <tfiala at google.com> wrote:

> Ah ok.  I'll move those in a minute.  Another check-in coming shortly
> before.
>
>
> On Tue, Aug 26, 2014 at 11:34 AM, Greg Clayton <gclayton at apple.com> wrote:
>
>> Todd:
>>
>> HostInfo::Intialize() should be done in Debugger::Initialize()
>> HostInfo::Terminate() should be done in Debugger::Terminate()
>>
>> We want there to be single call to initialize everything and terminate
>> everything and this is done via the Debugger calls.
>>
>> > On Aug 21, 2014, at 3:41 PM, Todd Fiala <todd.fiala at gmail.com> wrote:
>> >
>> > Author: tfiala
>> > Date: Thu Aug 21 17:41:25 2014
>> > New Revision: 216238
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=216238&view=rev
>> > Log:
>> > Add missing HostInfo::Initialize() in llgs.
>> >
>> > This fixes an llgs segfault on startup.
>> >
>> > Modified:
>> >    lldb/trunk/tools/lldb-gdbserver/lldb-gdbserver.cpp
>> >
>> > Modified: lldb/trunk/tools/lldb-gdbserver/lldb-gdbserver.cpp
>> > URL:
>> http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-gdbserver/lldb-gdbserver.cpp?rev=216238&r1=216237&r2=216238&view=diff
>> >
>> ==============================================================================
>> > --- lldb/trunk/tools/lldb-gdbserver/lldb-gdbserver.cpp (original)
>> > +++ lldb/trunk/tools/lldb-gdbserver/lldb-gdbserver.cpp Thu Aug 21
>> 17:41:25 2014
>> > @@ -32,6 +32,7 @@
>> > #include "lldb/Core/Debugger.h"
>> > #include "lldb/Core/PluginManager.h"
>> > #include "lldb/Core/StreamFile.h"
>> > +#include "lldb/Host/HostInfo.h"
>> > #include "lldb/Host/OptionParser.h"
>> > #include "lldb/Host/Socket.h"
>> > #include "lldb/Interpreter/CommandInterpreter.h"
>> > @@ -152,6 +153,7 @@ dump_available_platforms (FILE *output_f
>> > static void
>> > initialize_lldb_gdbserver ()
>> > {
>> > +    HostInfo::Initialize ();
>> >     PluginManager::Initialize ();
>> >     Debugger::Initialize (NULL);
>> > }
>> > @@ -159,7 +161,7 @@ initialize_lldb_gdbserver ()
>> > static void
>> > terminate_lldb_gdbserver ()
>> > {
>> > -    Debugger::Terminate();
>> > +    Debugger::Terminate ();
>> >     PluginManager::Terminate ();
>> > }
>> >
>> >
>> >
>> > _______________________________________________
>> > lldb-commits mailing list
>> > lldb-commits at cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>>
>> _______________________________________________
>> lldb-commits mailing list
>> lldb-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>>
>
>
>
> --
> Todd Fiala | Software Engineer |  tfiala at google.com |  650-943-3180
>



-- 
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140826/d615671a/attachment.html>