[Lldb-commits] [lldb] r215265 - Fix a bug where SetFilePermissions was calling MakeDirectory.

[Zachary Turner]

Hi Ed,

This change looks to have caused a test failure on FreeBSD.

http://llvm-amd64.freebsd.your.org/b/builders/lldb-amd64-freebsd/builds/2446/steps/check-lldb.1/logs/stdio

Any idea why this might be?  I'm pretty sure my change was correct, so
maybe something is wrong with the test or otherwise to have caused this.


On Fri, Aug 8, 2014 at 5:25 PM, Zachary Turner <zturner at google.com> wrote:

> Author: zturner
> Date: Fri Aug  8 19:25:50 2014
> New Revision: 215265
>
> URL: http://llvm.org/viewvc/llvm-project?rev=215265&view=rev
> Log:
> Fix a bug where SetFilePermissions was calling MakeDirectory.
>
> This appears to have been a copy / paste error.
>
> Modified:
>     lldb/trunk/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
>
> Modified: lldb/trunk/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp?rev=215265&r1=215264&r2=215265&view=diff
>
> ==============================================================================
> --- lldb/trunk/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp (original)
> +++ lldb/trunk/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp Fri Aug  8
> 19:25:50 2014
> @@ -109,7 +109,7 @@ Error
>  PlatformPOSIX::SetFilePermissions (const char *path, uint32_t
> file_permissions)
>  {
>      if (m_remote_platform_sp)
> -        return m_remote_platform_sp->MakeDirectory(path,
> file_permissions);
> +        return m_remote_platform_sp->SetFilePermissions(path,
> file_permissions);
>      else
>          return Platform::SetFilePermissions(path ,file_permissions);
>  }
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140808/4b17d813/attachment.html>