[Lldb-commits] [PATCH] Makefile.rules: Don't rely on the shell to perform wildcard expansion

David Majnemer david.majnemer at gmail.com
Wed Jul 30 15:31:47 PDT 2014


Hi zturner, tfiala,

It is possible to use make on Windows without using a Unix-like shell.
However, our makefile assumes that the shell is capable of glob
behavior.  Instead of hoping the shell will expand the wildcard, do it
upfront in the makefile itself.

http://reviews.llvm.org/D4731

Files:
  test/make/Makefile.rules

Index: test/make/Makefile.rules
===================================================================
--- test/make/Makefile.rules
+++ test/make/Makefile.rules
@@ -367,7 +367,7 @@
 all:	$(EXE) $(DSYM)
 clean::
 	$(RM) "$(EXE)" $(OBJECTS) $(PREREQS) $(ARCHIVE_NAME) $(ARCHIVE_OBJECTS)
-	$(RM) -r *.d.[0-9] *.d.[0-9][0-9] *.d.[0-9][0-9][0-9] *.d.[0-9][0-9][0-9][0-9] *.d.[0-9][0-9][0-9][0-9][0-9]
+	$(RM) -r $(wildcard *.d.[0-9] *.d.[0-9][0-9] *.d.[0-9][0-9][0-9] *.d.[0-9][0-9][0-9][0-9] *.d.[0-9][0-9][0-9][0-9][0-9])
 ifneq "$(DYLIB_NAME)" ""
 	$(RM) -r $(DYLIB_FILENAME).dSYM
 	$(RM) $(DYLIB_OBJECTS) $(DYLIB_PREREQS) $(DYLIB_FILENAME) $(DYLIB_FILENAME).debug
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4731.12048.patch
Type: text/x-patch
Size: 660 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140730/0a0b7a10/attachment.bin>


More information about the lldb-commits mailing list