[Lldb-commits] [PATCH] Add a .clang-format file to enhance formatting experience with clang-format

Chandler Carruth chandlerc at gmail.com
Tue Jul 22 15:33:54 PDT 2014


On Tue, Jul 22, 2014 at 2:52 PM, <jingham at apple.com> wrote:

> But touching a file doesn't mean you should also "fix up" its formatting
> with such a tool.  As long as THAT is part of our coding conventions, I
> guess I can't object.


>From my experience in Clang and LLVM the only way folks go in and do
extensive reformatting is when they're about to make absolutely *sweeping*
changes to the code. As in, rewrite the overwhelming majority of it. At
that point, doing more comprehensive updates to the formatting makes this
more consistent and well laid out in almost every case. This typically
isn't a blind application of the tool either, it is just a concerted effort
to bring all of the formatting in the file into a state that will be
consistent with the subsequent extensive changes.

And even then, they usually do it *first* so that those commits are clearly
known to be no-functionality-changed and the diffs which contain their
substantial rewrite can be reviewed reasonably without any noise from
reformatting code (yuck).

I don't know if or when that would ever be relevant for LLDB.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140722/7d117065/attachment.html>


More information about the lldb-commits mailing list