[Lldb-commits] [PATCH] Make the test runner understand Windows command shell execution.

[Todd Fiala]

This is the only tweak needed to your initial patch.  Below is the complete diff on test/plugins/builder_darwin.py:

```
Index: test/plugins/builder_darwin.py
===================================================================
--- test/plugins/builder_darwin.py	(revision 213654)
+++ test/plugins/builder_darwin.py	(working copy)
@@ -7,19 +7,13 @@
 
 def buildDsym(sender=None, architecture=None, compiler=None, dictionary=None, clean=True):
     """Build the binaries with dsym debug info."""
+    commands = []
+
     if clean:
-        lldbtest.system(["/bin/sh", "-c",
-                         "make clean" + getCmdLine(dictionary)
-                         + "; make MAKE_DSYM=YES"
-                         + getArchSpec(architecture) + getCCSpec(compiler)
-                         + getCmdLine(dictionary)],
-                        sender=sender)
-    else:
-        lldbtest.system(["/bin/sh", "-c",
-                         "make MAKE_DSYM=YES"
-                         + getArchSpec(architecture) + getCCSpec(compiler)
-                         + getCmdLine(dictionary)],
-                        sender=sender)
+        commands.append(["make", "clean", getCmdLine(dictionary)])
+    commands.append(["make", "MAKE_DSYM=YES", getArchSpec(architecture), getCCSpec(compiler), getCmdLine(dictionary)])
 
+    lldbtest.system(commands, sender=sender)
+
     # True signifies that we can handle building dsym.
     return True
```

(The incremental diff would be the square brackets added on the final commands.append() call.)

LGTM if you take care of adding those square brackets.

http://reviews.llvm.org/D4590