[Lldb-commits] [PATCH] [compiler-rt] ASan debugging API for report info extraction and locating addresses

Alexey Samsonov vonosmas at gmail.com
Wed Jul 16 14:20:42 PDT 2014


================
Comment at: lib/asan/asan_report.cc:35
@@ +34,3 @@
+struct ReportData {
+  bool already_happened = 0;
+  uptr pc = 0;
----------------
I believe this wouldn't compile on Windows :-/

================
Comment at: lib/asan/asan_report.cc:248
@@ -234,1 +247,3 @@
 
+static const uptr kMinimalDistanceFromAnotherGlobal = 64;
+
----------------
static is not necessary

http://reviews.llvm.org/D4527






More information about the lldb-commits mailing list