[Lldb-commits] [PATCH] Make the test runner understand Windows command shell execution.

[Zachary Turner]

Currently, the test runner makes the assumption that it will run commands through /bin/sh.  This is obviously not true on Windows, so this patch abstracts this logic out somewhat.  

Instead  of having the caller build the command string himself, the caller will now pass in argument list of the form [[a, b], [c, d], ...] which will get converted into a string of the form a b; c d or a b && c d, depending on the platform.  By specifying shell=True to Popen, this will pass the command to /bin/sh on Nix platforms, and cmd on Windows platforms.

Windows test runner is still broken after this change, but it gets further.

Will test on Linux soon and make appropriate fixes as necessary.

Untested on Mac / FreeBSD, would appreciate some help there if possible.

http://reviews.llvm.org/D4590

Files:
  test/functionalities/data-formatter/data-formatter-skip-summary/TestDataFormatterSkipSummary.py
  test/functionalities/single-quote-in-filename-to-lldb/TestSingleQuoteInFilename.py
  test/lang/cpp/virtual/TestVirtual.py
  test/lldbtest.py
  test/plugins/builder_base.py
  test/plugins/builder_darwin.py
  test/source-manager/TestSourceManager.py
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4590.11664.patch
Type: text/x-patch
Size: 11401 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140718/09dcb6e7/attachment.bin>