[Lldb-commits] Fix a bug with order of operations
zturner at google.com
Fri Jul 18 09:14:38 PDT 2014
Bump. This looks pretty benign to me so I'll probably go ahead and commit
without review if I don't hear back in the next, say, 6 hours or so.
On Thu, Jul 17, 2014 at 9:47 AM, Zachary Turner <zturner at google.com> wrote:
> I accidentally reversed the conditional on this patch. A corrected patch
> is attached.
> On Wed, Jul 16, 2014 at 1:42 PM, Zachary Turner <zturner at google.com>
>> Hi Greg,
>> Looks like a simple bug where it should have been "a | b | (c ? 0 : d)"
>> instead of "a | b | c ? 0 : d". Rather than rely on order of operations,
>> which I always find confusing, I opted to just move this out into explicit
>> initialization of the flags.
>> Let me know if the new code matches your original intent.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits