[Lldb-commits] [lldb] r212650 - Marked TestObjCMethods failing tests XFAIL, fixed cleanup code, removed now-passing expected failure markers.

Todd Fiala todd.fiala at gmail.com
Wed Jul 9 14:02:52 PDT 2014


Author: tfiala
Date: Wed Jul  9 16:02:52 2014
New Revision: 212650

URL: http://llvm.org/viewvc/llvm-project?rev=212650&view=rev
Log:
Marked TestObjCMethods failing tests XFAIL, fixed cleanup code, removed now-passing expected failure markers.

All tests matching '-p TestObjCMethods' now are marked correctly for MacOSX, and some
error classes have been removed in cleanup code looking for files that
might not exist due to previous failure.

See http://llvm.org/bugs/show_bug.cgi?id=20267

Modified:
    lldb/trunk/test/lang/objc/foundation/TestObjCMethods.py
    lldb/trunk/test/lang/objc/foundation/TestObjCMethods2.py

Modified: lldb/trunk/test/lang/objc/foundation/TestObjCMethods.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lang/objc/foundation/TestObjCMethods.py?rev=212650&r1=212649&r2=212650&view=diff
==============================================================================
--- lldb/trunk/test/lang/objc/foundation/TestObjCMethods.py (original)
+++ lldb/trunk/test/lang/objc/foundation/TestObjCMethods.py Wed Jul  9 16:02:52 2014
@@ -3,7 +3,7 @@ Set breakpoints on objective-c class and
 Also lookup objective-c data types and evaluate expressions.
 """
 
-import os, time
+import os, os.path, time
 import unittest2
 import lldb
 import string
@@ -119,6 +119,7 @@ class FoundationTestCase(TestBase):
         self.expression_lookups_objc()
 
     @dwarf_test
+    @expectedFailureDarwin("llvm.org/pr20267")
     def test_expression_lookups_objc_dwarf(self):
         """Test running an expression detect spurious debug info lookups (DWARF)."""
         self.buildDwarf()
@@ -141,7 +142,8 @@ class FoundationTestCase(TestBase):
         self.runCmd("log disable dwarf lookups")
         
         def cleanup():
-            os.unlink (logfile)
+            if os.path.exists (logfile):
+                os.unlink (logfile)
         
         self.addTearDownHook(cleanup)
         

Modified: lldb/trunk/test/lang/objc/foundation/TestObjCMethods2.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lang/objc/foundation/TestObjCMethods2.py?rev=212650&r1=212649&r2=212650&view=diff
==============================================================================
--- lldb/trunk/test/lang/objc/foundation/TestObjCMethods2.py (original)
+++ lldb/trunk/test/lang/objc/foundation/TestObjCMethods2.py Wed Jul  9 16:02:52 2014
@@ -133,7 +133,6 @@ class FoundationTestCase2(TestBase):
 
         self.runCmd("process continue")
 
-    @unittest2.expectedFailure(8741897)
     def NSArray_expr(self):
         """Test expression commands for NSArray."""
         exe = os.path.join(os.getcwd(), "a.out")





More information about the lldb-commits mailing list