[Lldb-commits] [PATCH] Invalidate process uid/gid command options on Windows

jingham at apple.com jingham at apple.com
Mon Jul 7 14:59:07 PDT 2014


This seems okay.  It bugs me a little that I can get the platform two ways now, from the target & from the explicit platform.  It only makes sense if the two are the same, but it would be nice if there were some way to formalize that...

Jim
  
> On Jul 7, 2014, at 1:21 PM, Zachary Turner <zturner at google.com> wrote:
> 
> Update the patch to take both an ExecutionContext and a Platform independently of each other.  The core logic has not changed, this particular validator still goes through the Platform and ignores the Target, since there may be no target running.
> 
> http://reviews.llvm.org/D4373
> 
> Files:
>  include/lldb/Host/OptionParser.h
>  include/lldb/Interpreter/CommandOptionValidators.h
>  include/lldb/Interpreter/Options.h
>  include/lldb/lldb-private-types.h
>  source/Commands/CommandObjectPlatform.cpp
>  source/Interpreter/Args.cpp
>  source/Interpreter/CMakeLists.txt
>  source/Interpreter/CommandOptionValidators.cpp
>  source/Interpreter/Options.cpp
> <D4373.11127.patch>_______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits




More information about the lldb-commits mailing list