[Lldb-commits] [PATCH] Don't truncate the target triple when initializing clang

[Sean Callanan]

I have some cycles to look at this while I’m doing a build.

The original patch that brought this in is
–
Author: spyffe
Date: Wed Apr 13 21:01:31 2011
New Revision: 129500

URL: http://llvm.org/viewvc/llvm-project?rev=129500&view=rev
Log:
Updated LLVM to pick up fixes to the ARM instruction
tables.

Modified:
   lldb/trunk/llvm.zip
   lldb/trunk/scripts/build-llvm.pl
   lldb/trunk/source/Expression/ClangExpressionParser.cpp
   lldb/trunk/source/Expression/IRDynamicChecks.cpp
   lldb/trunk/source/Expression/IRForTarget.cpp
–
At the time, I was working on the ARM/Thumb disassemblers.  It may have been that at the time the target triples were in flux.
I don’t think there’s a specific use case that depends on this at this time, and if there is one, we can revisit it.
Go ahead and take this out.

Sean

> On Jun 26, 2014, at 11:15 AM, Todd Fiala <tfiala at google.com> wrote:
> 
> LGTM - here's how I tested:
> 
> Linux x86_64:
> (lldb) file /path/to/exe
> (lldb) b main.cpp:10
> (lldb) run
> ... at breakpoint ...
> (lldb) expr 5*3
> // prints result as expected
> 
> Same result for MacOSX 10.9.3 with x86_64 MacOS executable.
> 
> Let's ping the Apple folks and see if there is some kind of simulator/device that make choke on that, though, before you check this in.
> 
> http://reviews.llvm.org/D4282
> 
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140627/bfdee268/attachment.html>