[Lldb-commits] [PATCH] Allow MachO JIT debugging

Keno Fischer kfischer at college.harvard.edu
Tue Jun 24 17:53:55 PDT 2014


Sorry about that. Your patch looks good to me.


On Tue, Jun 24, 2014 at 8:46 PM, Zachary Turner <zturner at google.com> wrote:

> This patch broke the Windows build, and also I believe had a bug.  I've
> uploaded a fix here [http://reviews.llvm.org/D4284] if someone doesn't
> mind taking a look.
>
>
> On Tue, Jun 24, 2014 at 3:32 PM, Greg Clayton <gclayton at apple.com> wrote:
>
>> % svn commit
>> Sending        include/lldb/Core/Section.h
>> Sending        lib/Makefile
>> Sending        source/Core/Section.cpp
>> Sending        source/Expression/IRExecutionUnit.cpp
>> Sending        source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
>> Sending        source/Plugins/Makefile
>> Sending        source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
>> Sending        source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
>> Sending        source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
>> Transmitting file data .........
>> Committed revision 211638.
>>
>> I committed the changes, but left it disabled by default on apple vendors
>> because of performance regressions that caused us to disable this in the
>> first place. We can talk about how and when we enable this when vendor ==
>> apple in the near future.
>>
>> Greg
>>
>> > On Jun 24, 2014, at 3:03 PM, Keno Fischer <kfischer at college.harvard.edu>
>> wrote:
>> >
>> > Ok, great! I don't have commit access, so would you mind committing
>> this?
>> >
>> >
>> > On Tue, Jun 24, 2014 at 5:50 PM, Greg Clayton <gclayton at apple.com>
>> wrote:
>> > Looks good.
>> >
>> > > On Jun 19, 2014, at 10:41 AM, Keno Fischer <
>> kfischer at college.harvard.edu> wrote:
>> > >
>> > > Slight adjustment to updateSectionLoadAddress to properly adjust the
>> load address range of fake segments.
>> > >
>> > > http://reviews.llvm.org/D4006
>> > >
>> > > Files:
>> > >  include/lldb/Core/Section.h
>> > >  lib/Makefile
>> > >  source/Core/Section.cpp
>> > >  source/Expression/IRExecutionUnit.cpp
>> > >  source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
>> > >  source/Plugins/Makefile
>> > >  source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
>> > >  source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
>> > >  source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
>> > > <D4006.10646.patch>_______________________________________________
>> > > lldb-commits mailing list
>> > > lldb-commits at cs.uiuc.edu
>> > > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>> >
>> >
>>
>> _______________________________________________
>> lldb-commits mailing list
>> lldb-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140624/abf6bc8e/attachment.html>


More information about the lldb-commits mailing list