[Lldb-commits] [PATCH] Make methods of exported API classes that access internal types private.

Zachary Turner zturner at google.com
Tue May 27 17:46:23 PDT 2014


Hi tfiala,

As part of the contract of a dll-exported C++ interface, classes that are not exported should not be accessible via a public interface of an exported class, and doing so generates warnings on MSVC.  These warnings can be safely suprressed as long as all non-exported classes are part of the exported class's private interface, so this change moves all such methods to the private interface, friending where necessary, and finally suppresses the warnings on MSVC.

http://reviews.llvm.org/D3934

Files:
  CMakeLists.txt
  include/lldb/API/SBDebugger.h
  include/lldb/API/SBFrame.h
  include/lldb/API/SBProcess.h
  include/lldb/API/SBQueueItem.h
  include/lldb/API/SBTarget.h
  include/lldb/API/SBThread.h
  include/lldb/API/SBValue.h
  include/lldb/API/SBWatchpoint.h
  source/API/SBDebugger.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D3934.9856.patch
Type: text/x-patch
Size: 8044 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140528/20f63f7e/attachment.bin>


More information about the lldb-commits mailing list